qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several


From: Romain Dolbeau
Subject: Re: [Qemu-devel] [PATCH] e1000: add the ability to select among several specific types of e1000, plus some pointers to documentations and details.
Date: Tue, 25 Feb 2014 10:24:30 +0100

2014-02-25 9:58 GMT+01:00 Romain Dolbeau <address@hidden>:
2014-02-25 9:01 GMT+01:00 Andreas Färber <address@hidden>:

> @@ -1572,6 +1572,9 @@ static const char * const pci_nic_models[] = {
> @@ -1584,6 +1587,9 @@ static const char * const pci_nic_names[] = {

I would hope that adding to these two legacy lists is not necessary for
new types. They should be created using -device, not -net nic,model=.

Again I don't understand - I took inspiration from eepro100.c, and it has 3 devices in there
(i82551, i82557b, i82559er). And the model is handled by -device, as my example
shows:
#####
"-netdev user,id=mynet0 -device 82545EM,netdev=mynet0"
#####

I was misled by the presence of "e1000" and several eepro100 variants in this list.
Modifying it is not necessary, it works fine without it. I suppose that's what you
meant - that it works both ways (-device or -net nic), but the second option is not
required for new device as it's a deprecated way of doing things?

Cordially,
 
--
Romain Dolbeau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]