[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h |
Date: |
Tue, 25 Feb 2014 00:00:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
Am 24.02.2014 11:26, schrieb Paolo Bonzini:
> Il 23/02/2014 18:02, Stefan Weil ha scritto:
>> diff --git a/qga/channel-win32.c b/qga/channel-win32.c
>> index 8a303f3..3a0bf13 100644
>> --- a/qga/channel-win32.c
>> +++ b/qga/channel-win32.c
>> @@ -2,7 +2,7 @@
>> #include <stdio.h>
>> #include <stdbool.h>
>> #include <glib.h>
>> -#include <windows.h>
>> +#include "sysemu/os-winapi.h"
>> #include <errno.h>
>> #include <io.h>
>> #include "qga/guest-agent-core.h"
>
> qga/ is not supposed to include include/sysemu (which is just for
> qemu-system-*). I guess you can call the new file include/qemu/winapi.h
>
> Paolo
Ah, thanks for explaining. I'll use the suggested name in an updated
series. But you are aware that qga/ already includes sysemu/os-posix.h
and sysemu/os-win32.h indirectly? Should those two files also be in
include/qemu?
Stefan
Re: [Qemu-devel] [PATCH 9/9] w32: Replace Windows specific data types in common header files, Andreas Färber, 2014/02/24
[Qemu-devel] [PATCH 6/9] w32: Add and use intermediate include file for windows.h, Stefan Weil, 2014/02/23
[Qemu-devel] [PATCH 5/9] vl: Remove unneeded include file, Stefan Weil, 2014/02/23
[Qemu-devel] [PATCH 2/9] exec: Remove unneeded include files, Stefan Weil, 2014/02/23
[Qemu-devel] [PATCH 8/9] w32: Reduce dependencies in sysemu/os-win32.h, Stefan Weil, 2014/02/23
[Qemu-devel] [PATCH 7/9] w32: Move inline function from header file to C source, Stefan Weil, 2014/02/23
[Qemu-devel] [PATCH 1/9] util/iov: Use qemu/sockets.h instead of conditional code, Stefan Weil, 2014/02/23
Re: [Qemu-devel] [PATCH 0/9] w32: Reduce dependency on Windows API, Stefan Weil, 2014/02/25