[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/musicpal: Remove nonexistent CDTP2, CDTP3 registers |
Date: |
Mon, 24 Feb 2014 15:45:13 +0000 |
On 21 February 2014 07:15, Jan Kiszka <address@hidden> wrote:
> On 2014-02-18 16:28, Peter Maydell wrote:
>> The ethernet device in the musicpal only has two tx queues,
>> but we modelled it with four CTDP registers, presumably a
>> cut and paste from the rx queue registers. Since the tx_queue[]
>> array is only 2 entries long this allowed a guest to overrun
>> this buffer. Remove the nonexistent registers.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>
> Acked-by: Jan Kiszka <address@hidden>
Thanks, applied to target-arm.next (with added cc:stable line).
-- PMM