[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] tcg/i386: Fix build for systems without work
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] tcg/i386: Fix build for systems without working cpuid.h (MacOSX, Win32) |
Date: |
Fri, 21 Feb 2014 11:36:48 +0000 |
On 20 February 2014 21:08, Richard Henderson <address@hidden> wrote:
> On 02/20/2014 01:42 PM, Peter Maydell wrote:
>> Win32 doesn't have a cpuid.h, and MacOSX may have one but without
>> the __cpuid() function we use, which means that commit 9d2eec20
>> broke the build for those platforms. Fix this by tightening up
>> our configure cpuid.h check to test that the functions we need
>> are present, and adding some missing #ifdef guards in
>> tcg/i386/tcg-target.c.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> Changes v1->v2: fix typo in commit message, add __cpuid_count()
>> to the configure test
>>
>> configure | 13 ++++++++++++-
>> tcg/i386/tcg-target.c | 4 +++-
>> 2 files changed, 15 insertions(+), 2 deletions(-)
>
> Reviewed-by: Richard Henderson <address@hidden>
Thanks; applied to master.
-- PMM