Re: [Qemu-devel] [PATCH] scsi-disk: Add support for port WWN and index descriptors in VPD page 83h

[Paolo Bonzini]

Il 20/02/2014 18:14, Roland Dreier ha scritto:
> > > Looks like _ is more common than - for device properties:
> > >
> > > $ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l
> > > 132
> > > $ git grep DEFINE_PROP_.*\(\".*-.*\" | wc -l
> > > 77
> And more locally, "scsi-id" in scsi-bus.c is the only property in
> hw/scsi with a '-'.  scsi-disk.c already has "max_unmap_size" and
> megasas.c has several '_' already.
>
> With that said I'm fine either way, and if you want to munge my patch
> to use '-' that's perfectly OK with me.  Or I'm happy to resubmit in
> the other form.

No, your patch is fine.  We'll sort out what to do with underscores and 
dashes, looks like there is a plan...

Thanks for your contribution to QEMU!

Paolo