Re: [Qemu-devel] Buildbot failure: MinGW

[Peter Maydell]

On 19 February 2014 12:18, Thomas Huth <address@hidden> wrote:
> I recently had a similar problem compiling QEMU on a freshly installed
> system, where I only had a normal C compiler, but no C++ installed yet.
>
> In rules.mak, you can find these lines:
>
>  # If we have a CXX we might have some C++ objects, in which case we
>  # must link with the C++ compiler, not the plain C compiler.
>  LINKPROG = $(or $(CXX),$(CC))
>
> So that's ok, it sets LINKPROG to the c++ compiler if the variable is
> set, and to the C compiler if not.
>
> But now have a look at the configure script:
>
>  if test -z "${CXX}${cross_prefix}"; then
>    cxx="c++"
>  else
>    cxx="${CXX-${cross_prefix}g++}"
>  fi
>
>  [...]
>
>  echo "CXX=$cxx" >> $config_host_mak
>
> That seems to always set the CXX variable! I think the above
> if-statement is wrong, it should set cxx only if the c++ program is
> really available.

Yes, you're right. Certainly my intention with the vixl changes
was to only build with C++ if a C++ compiler was present; I
must have misread this bit of configure. I'll put together a patch.

thanks
-- PMM