Re: [Qemu-devel] [PATCH v2 0/3] qtest: avoid pidfile and QEMU process leaks

[Markus Armbruster]

Stefan Hajnoczi <address@hidden> writes:

> v2:
>  * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo]
>  * Use sigemptyset() to avoid assumption about signal mask [Markus]
>  * if (fd != -1) close(fd) is no longer necessary [Markus]
>
> This series prevents the following qtest issues:
>
> 1. Leaking the pidfile if QEMU startup fails, as discovered by Andreas Färber.
> 2. Leaking the QEMU process when a test case aborts.
>
> Applying this series should make buildbots and manual "make check" users have 
> a
> more pleasant and less leaky experience :).
>
> Stefan Hajnoczi (3):
>   qtest: drop unused child_pid field
>   qtest: make QEMU our direct child process
>   qtest: kill QEMU process on g_assert() failure
>
>  tests/libqtest.c | 59 
> +++++++++++++++++++++++++-------------------------------
>  1 file changed, 26 insertions(+), 33 deletions(-)

Reviewed-by: Markus Armbruster <address@hidden>