[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage |
Date: |
Tue, 18 Feb 2014 10:32:31 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* address@hidden (address@hidden) wrote:
> From: "Michael R. Hines" <address@hidden>
>
> We also later export these statistics over QMP for better
> monitoring of micro-checkpointing as the workload changes.
<snip>
> @@ -548,9 +568,11 @@ static int ram_save_block(QEMUFile *f, bool last_stage)
> /* XBZRLE overflow or normal page */
> if (bytes_sent == -1) {
> bytes_sent = save_block_hdr(f, block, offset, cont,
> RAM_SAVE_FLAG_PAGE);
> - qemu_put_buffer_async(f, p, TARGET_PAGE_SIZE);
> - bytes_sent += TARGET_PAGE_SIZE;
> - acct_info.norm_pages++;
> + if (ret != RAM_SAVE_CONTROL_DELAYED) {
> + qemu_put_buffer_async(f, p, TARGET_PAGE_SIZE);
> + bytes_sent += TARGET_PAGE_SIZE;
> + acct_info.norm_pages++;
> + }
> }
Is that last change intended for this patch; it doesn't look
timestamp related.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, (continued)
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, Dr. David Alan Gilbert, 2014/02/19
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, Michael R. Hines, 2014/02/19
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, Dr. David Alan Gilbert, 2014/02/20
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, Li Guang, 2014/02/20
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, Michael R. Hines, 2014/02/20
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, Michael R. Hines, 2014/02/20
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, Dr. David Alan Gilbert, 2014/02/20
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, Michael R. Hines, 2014/02/20
- Re: [Qemu-devel] [RFC PATCH v2 01/12] mc: add documentation for micro-checkpointing, Dr. David Alan Gilbert, 2014/02/21
[Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage, mrhines, 2014/02/18
- Re: [Qemu-devel] [RFC PATCH v2 02/12] mc: timestamp migration_bitmap and KVM logdirty usage,
Dr. David Alan Gilbert <=
[Qemu-devel] [RFC PATCH v2 03/12] mc: introduce a 'checkpointing' status check into the VCPU states, mrhines, 2014/02/18
[Qemu-devel] [RFC PATCH v2 04/12] mc: support custom page loading and copying, mrhines, 2014/02/18
[Qemu-devel] [RFC PATCH v2 05/12] rdma: accelerated memcpy() support and better external RDMA user interfaces, mrhines, 2014/02/18
[Qemu-devel] [RFC PATCH v2 06/12] mc: introduce state machine changes for MC, mrhines, 2014/02/18