[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 5/8] block: Remove bdrv_new() from bdrv_file_open
From: |
Max Reitz |
Subject: |
[Qemu-devel] [PATCH v3 5/8] block: Remove bdrv_new() from bdrv_file_open() |
Date: |
Sat, 15 Feb 2014 04:30:21 +0100 |
Change bdrv_file_open() to take a simple pointer to an already existing
BDS instead of an indirect one. The BDS will be created in bdrv_open()
if necessary.
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Benoit Canet <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
---
block.c | 24 +++++++++++++-----------
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/block.c b/block.c
index a1adf93..7243630 100644
--- a/block.c
+++ b/block.c
@@ -953,10 +953,9 @@ free_and_fail:
* after the call (even on failure), so if the caller intends to reuse the
* dictionary, it needs to use QINCREF() before calling bdrv_file_open.
*/
-static int bdrv_file_open(BlockDriverState **pbs, const char *filename,
+static int bdrv_file_open(BlockDriverState *bs, const char *filename,
QDict *options, int flags, Error **errp)
{
- BlockDriverState *bs = NULL;
BlockDriver *drv;
const char *drvname;
bool allow_protocol_prefix = false;
@@ -968,7 +967,6 @@ static int bdrv_file_open(BlockDriverState **pbs, const
char *filename,
options = qdict_new();
}
- bs = bdrv_new("");
bs->options = options;
options = qdict_clone_shallow(options);
@@ -1042,7 +1040,6 @@ static int bdrv_file_open(BlockDriverState **pbs, const
char *filename,
QDECREF(options);
bs->growable = 1;
- *pbs = bs;
return 0;
fail:
@@ -1050,7 +1047,6 @@ fail:
if (!bs->drv) {
QDECREF(bs->options);
}
- bdrv_unref(bs);
return ret;
}
@@ -1246,18 +1242,24 @@ int bdrv_open(BlockDriverState **pbs, const char
*filename,
return 0;
}
- if (flags & BDRV_O_PROTOCOL) {
- assert(!drv);
- return bdrv_file_open(pbs, filename, options, flags & ~BDRV_O_PROTOCOL,
- errp);
- }
-
if (*pbs) {
bs = *pbs;
} else {
bs = bdrv_new("");
}
+ if (flags & BDRV_O_PROTOCOL) {
+ assert(!drv);
+ ret = bdrv_file_open(bs, filename, options, flags & ~BDRV_O_PROTOCOL,
+ errp);
+ if (ret && !*pbs) {
+ bdrv_unref(bs);
+ } else if (!ret) {
+ *pbs = bs;
+ }
+ return ret;
+ }
+
/* NULL means an empty set of options */
if (options == NULL) {
options = qdict_new();
--
1.8.5.4
- [Qemu-devel] [PATCH v3 0/8] block: Integrate bdrv_file_open() into bdrv_open(), Max Reitz, 2014/02/14
- [Qemu-devel] [PATCH v3 1/8] block: Change BDS parameter of bdrv_open() to **, Max Reitz, 2014/02/14
- [Qemu-devel] [PATCH v3 2/8] block: Add reference parameter to bdrv_open(), Max Reitz, 2014/02/14
- [Qemu-devel] [PATCH v3 3/8] block: Make bdrv_file_open() static, Max Reitz, 2014/02/14
- [Qemu-devel] [PATCH v3 4/8] block: Reuse reference handling from bdrv_open(), Max Reitz, 2014/02/14
- [Qemu-devel] [PATCH v3 5/8] block: Remove bdrv_new() from bdrv_file_open(),
Max Reitz <=
- [Qemu-devel] [PATCH v3 6/8] block: Handle bs->options in bdrv_open() only, Max Reitz, 2014/02/14
- [Qemu-devel] [PATCH v3 7/8] block: Reuse success path from bdrv_open(), Max Reitz, 2014/02/14
- [Qemu-devel] [PATCH v3 8/8] block: Remove bdrv_open_image()'s force_raw option, Max Reitz, 2014/02/14
- Re: [Qemu-devel] [PATCH v3 0/8] block: Integrate bdrv_file_open() into bdrv_open(), Kevin Wolf, 2014/02/17