|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v2 09/20] cow: correctly propagate errors |
Date: | Fri, 14 Feb 2014 21:22:42 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Il 14/02/2014 19:19, Kevin Wolf ha scritto:
Eventually this function will return void; having both a -errno return and the errp argument is just an intermediate step (as probably in all other cases). So I still think this is going in the wrong direction and will make the conversion harder than necessary. Now that this patch series is already here, I won't insist on respinning it, but please be aware that you're just creating additional work for other people and keep existing local_errs in any future patches.
Ok, this makes sense, but it is an exception to the general policy. :) I'll respin v3 and test NBD too. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |