[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] tests-ppc64: add to cleanup rule |
Date: |
Fri, 14 Feb 2014 15:03:15 +1100 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/11/2014 07:32 AM, Andreas Färber wrote:
> Am 10.02.2014 04:52, schrieb Alexey Kardashevskiy:
>> This adds $(check-qtest-ppc64-y) to the check-clean rule.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>
> Nice catch!
>
>> ---
>> tests/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/Makefile b/tests/Makefile
>> index 0aaf657..3a00ea7 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -319,7 +319,7 @@ check-block: $(patsubst %,check-%, $(check-block-y))
>> check: check-qapi-schema check-unit check-qtest
>> check-clean:
>> $(MAKE) -C tests/tcg clean
>> - rm -rf $(check-unit-y) $(check-qtest-i386-y) $(check-qtest-x86_64-y)
>> $(check-qtest-sparc64-y) $(check-qtest-sparc-y) tests/*.o
>> $(QEMU_IOTESTS_HELPERS-y)
>> + rm -rf $(check-unit-y) $(check-qtest-i386-y) $(check-qtest-x86_64-y)
>> $(check-qtest-sparc64-y) $(check-qtest-sparc-y) $(check-qtest-ppc64-y)
>> tests/*.o $(QEMU_IOTESTS_HELPERS-y)
>>
>> clean: check-clean
>>
>
> Can we use a $(foreach ...) for $(check-qtest-*-y) like Peter did for
> adding qom-test?
>
> http://patchwork.ozlabs.org/patch/313650/
Like this? Against what should I rebase my patches and repost them?
diff --git a/tests/Makefile b/tests/Makefile
index 94b32b7..2577843 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -323,7 +323,9 @@ check-block: $(patsubst %,check-%, $(check-block-y))
check: check-qapi-schema check-unit check-qtest
check-clean:
$(MAKE) -C tests/tcg clean
- rm -rf $(check-unit-y) $(check-qtest-i386-y)
$(check-qtest-x86_64-y) $(check-qtest-sparc64-y) $(check-qtest-sparc-y) t
+ $(eval rmlist = $(check-unit-y) tests/*.o $(QEMU_IOTESTS_HELPERS-y))
+ $(foreach target,$(SYSEMU_TARGET_LIST), $(eval rmlist +=
$(check-qtest-$(target)-y)))
+ rm -rf $(rmlist)
clean: check-clean
--
Alexey
- [Qemu-devel] [PATCH qom-next v2 04/12] tests: Add pcnet qtest, (continued)
- [Qemu-devel] [PATCH qom-next v2 04/12] tests: Add pcnet qtest, Andreas Färber, 2014/02/09
- [Qemu-devel] [PATCH qom-next v2 03/12] tests: Add rtl8139 qtest, Andreas Färber, 2014/02/09
- [Qemu-devel] [PATCH qom-next v2 07/12] tests: Add ne2000 qtest, Andreas Färber, 2014/02/09
- [Qemu-devel] [PATCH qom-next v2 12/12] tests: Add ipoctal232 qtest, Andreas Färber, 2014/02/09
- [Qemu-devel] [PATCH qom-next v2 10/12] tests: Add virtio-balloon qtest, Andreas Färber, 2014/02/09
- [Qemu-devel] [PATCH qom-next v2 11/12] tests: Add virtio-rng qtest, Andreas Färber, 2014/02/09
- Re: [Qemu-devel] [PATCH qom-next v2 00/12] qtest: Prepare PCI NIC, virtio, IndustryPack tests, Alexey Kardashevskiy, 2014/02/09
- [Qemu-devel] [PATCH 0/2] tests-ppc64: add spapr phb test, Alexey Kardashevskiy, 2014/02/09
- [Qemu-devel] [PATCH 2/2] tests-ppc64: test for -device spapr-pci-host-bridge, Alexey Kardashevskiy, 2014/02/09
Re: [Qemu-devel] [PATCH qom-next v2 00/12] qtest: Prepare PCI NIC, virtio, IndustryPack tests, Stefan Hajnoczi, 2014/02/10