Re: [Qemu-devel] [PULL 2/3] s390-ccw.img: Fix sporadic errors with ccw boot image - initialize css

[Peter Maydell]

On 13 February 2014 10:05, Christian Borntraeger <address@hidden> wrote:
> On 13/02/14 10:55, Peter Maydell wrote:
>> On 13 February 2014 09:17, Christian Borntraeger <address@hidden> wrote:
>>>  static void virtio_setup(uint64_t dev_info)
>>>  {
>>> +    struct subchannel_id blk_schid = { .one = 1};
>>
>> Missing space before the "}" I think.
>
> checkpatch accepts both ways:
> a)    struct subchannel_id blk_schid = { .one = 1};
> b)    struct subchannel_id blk_schid = { .one = 1 };
>
> so, change it or keep it?

checkpatch isn't infallible. I think having the space
looks better. In any case you should be consistent
about whether you use a space with both the opening
and the closing brace -- at the moment you've got a
space at one end and not the other.

thanks
-- PMM