Re: [Qemu-devel] [PATCH 19/20] block: do not abuse EMEDIUMTYPE

[Paolo Bonzini]

Il 10/02/2014 09:47, Fam Zheng ha scritto:
> > > @@ -449,7 +449,7 @@ static int qcow2_open(BlockDriverState *bs, QDict 
> > *options, int flags,
> > >
> > >      if (header.magic != QCOW_MAGIC) {
> > >          error_setg(errp, "Image is not in qcow2 format");
> It might be good to have a consistent message pattern in qcow2 as others.

Right, I'll fix the others.

> Is it worth adding a QERR_ error class for unexpected format magic?

We're not adding QERR_ anymore, but if anyone has ideas I can do 
something to improve the homogeneity of the errors.

Paolo