Re: [Qemu-devel] [PATCH 01/10] tests/qapi-schema: Actually check successful QMP command response

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 02/06/2014 07:29 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  tests/test-qmp-commands.c | 44 ++++++++++++++++++++++++++++++++++++--------
>>  1 file changed, 36 insertions(+), 8 deletions(-)
>> 
>> diff --git a/tests/test-qmp-commands.c b/tests/test-qmp-commands.c
>> index 5a3e82a..2416d07 100644
>> --- a/tests/test-qmp-commands.c
>> +++ b/tests/test-qmp-commands.c
>> @@ -71,6 +71,24 @@ static void test_dispatch_cmd_error(void)
>>      QDECREF(req);
>>  }
>>  
>> +static QObject *
>> +test_qmp_dispatch(QDict *req)
>
> Doesn't qemu style prefer this all on one line?
>
> Reviewed-by: Eric Blake <address@hidden>

It does, but my fingers still hate it...

I'll wait a bit before I respin, to give others a chance to comment.

Thanks for your prompt review!