Re: [Qemu-devel] [PATCH 1/2] qom-test: Run for all available machines

[Stefano Stabellini]

On Wed, 5 Feb 2014, Andreas Färber wrote:
> Stefano,
> 
> Am 10.01.2014 14:31, schrieb address@hidden:
> > From: Markus Armbruster <address@hidden>
> > 
> > Get available machines via QMP instead of hardcoding a list that's
> > perpetually out of date.
> > 
> > A few machines don't work out of the box:
> [...]
> > * Xen machines can work only when running under the Xen hypervisor.
> > 
> > Blacklist them.
> > 
> > Signed-off-by: Markus Armbruster <address@hidden>
> > ---
> >  tests/qom-test.c | 283 
> > +++++++++++++------------------------------------------
> >  1 file changed, 66 insertions(+), 217 deletions(-)
> > 
> > diff --git a/tests/qom-test.c b/tests/qom-test.c
> > index 5e5af7a..3cbd480 100644
> > --- a/tests/qom-test.c
> > +++ b/tests/qom-test.c
> > @@ -11,6 +11,42 @@
> >  #include <glib.h>
> >  #include <string.h>
> >  #include "qemu/osdep.h"
> > +#include "qapi/qmp/types.h"
> > +
> [...]
> > +
> > +static const char *blacklist_x86[] = {
> > +    "xenfv", "xenpv", NULL
> > +};
> [snip]
> 
> I'm wondering if we could enable these machines conditional to
> CONFIG_XEN, so I've tried commenting out the two since I have the Xen
> libraries installed, but I get this:
> 
> $ make check-qtest V=1
> [...]
>   /i386/qom/xenpv:
> xen be core: can't connect to xenstored
> xen_init_pv: xen backend core setup failed
> Broken pipe
> FAIL
> [...]
>   /i386/qom/xenfv:
> Broken pipe
> FAIL
> [...]
> 
> Have you checked whether you can make some code dependent on
> !qtest_enabled() to make your machines testable by non-Xen users?

No, I haven't.
I think that there is no way we could make xenpv work as it is too
dependent on xenstore. However we should be able to make xenfv and
pc,accel=xen work.