[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus"
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] Revert "nand: Don't inherit from Sysbus" |
Date: |
Wed, 5 Feb 2014 14:28:31 +0000 |
On 5 February 2014 13:00, Peter Maydell <address@hidden> wrote:
> On 5 February 2014 12:24, Markus Armbruster <address@hidden> wrote:
>> As to why it's complicated for Peter to fix, here's what Peter wrote:
>> "That series got very big on me with complications. I think near term
>> we just proceed with the revert. Sorry for the delay." I have no
>> reason to second-guess him.
>>
>> Promptly reverting patches that cause regressions when a fix isn't ready
>> is standard operating procedure. We can delay a revert a reasonable
>> amount of time to deliberate what to do, and perhaps find a fix. We did
>> that, and then some: four weeks. We should revert, and try again.
>> Neither harm nor shame in that.
>
> I agree in general here, which is why I'm going to apply this patch.
Following conversation on IRC and Andreas' recent patch:
given that the current state of affairs (ie 'info qtest crashes') has been
in master for six months, there doesn't seem to be a critically urgent
need to act immediately, so I'm going to give it a few days to check
that we have a consensus on the best way to deal with this.
thanks
-- PMM