[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler"
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler" link |
Date: |
Mon, 03 Feb 2014 13:50:02 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 02/03/2014 01:38 PM, Igor Mammedov wrote:
>>> +static inline void qbus_set_hotplug_handler(BusState *bus, DeviceState
>>> *handler,
>>> + Error **errp)
>>> +{
>>> + object_property_set_link(OBJECT(bus), OBJECT(handler),
>>> + QDEV_HOTPLUG_HANDLER_PROPERTY, errp);
>>> + bus->allow_hotplug = 1;
>>
>> Should we convert allow_hotplug to bool over the course of this series?
> There isn't much point in touching it, since it's going to be removed once
> all hotplug-able buses are converted to new interface.
After finishing my read through your series, I noticed that you were
using allow_hotplug less and less and instead using a new bool in most
code you added. Does that just mean your series didn't touch every last
client of the old interface, and that there still remains code to be
converted, where this series serves as the example of how?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v5 3/9] qdev: add "hotpluggable" property to Device, Igor Mammedov, 2014/02/03
[Qemu-devel] [PATCH v5 4/9] hw/acpi: move typeinfo to the file end, Igor Mammedov, 2014/02/03
[Qemu-devel] [PATCH v5 5/9] qdev:pci: refactor PCIDevice to use generic "hotpluggable" property, Igor Mammedov, 2014/02/03
[Qemu-devel] [PATCH v5 7/9] pci/shpc: convert SHPC hotplug to use hotplug-handler API, Igor Mammedov, 2014/02/03
[Qemu-devel] [PATCH v5 6/9] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API, Igor Mammedov, 2014/02/03
[Qemu-devel] [PATCH v5 8/9] pci/pcie: convert PCIE hotplug to use hotplug-handler API, Igor Mammedov, 2014/02/03