[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler"
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/9] qdev: add to BusState "hotplug-handler" link |
Date: |
Mon, 03 Feb 2014 12:30:04 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 02/03/2014 08:57 AM, Igor Mammedov wrote:
> It will allow to reuse field with different BUSes,
> reducing code duplication. Field is intended for
> replacing 'hotplug_qdev' field in PCIBus and also
> will allow to avoid adding equivalent field to
> DimmBus with possiblitity to refactor other BUSes
> to use it instead of custom field.
> In addition once all users of allow_hotplug field
> are converted to new API, link could replace
> allow_hotplug field in qdev hotplug code.
>
> +static inline void qbus_set_hotplug_handler(BusState *bus, DeviceState
> *handler,
> + Error **errp)
> +{
> + object_property_set_link(OBJECT(bus), OBJECT(handler),
> + QDEV_HOTPLUG_HANDLER_PROPERTY, errp);
> + bus->allow_hotplug = 1;
Should we convert allow_hotplug to bool over the course of this series?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v5 3/9] qdev: add "hotpluggable" property to Device, Igor Mammedov, 2014/02/03
[Qemu-devel] [PATCH v5 4/9] hw/acpi: move typeinfo to the file end, Igor Mammedov, 2014/02/03
[Qemu-devel] [PATCH v5 5/9] qdev:pci: refactor PCIDevice to use generic "hotpluggable" property, Igor Mammedov, 2014/02/03
[Qemu-devel] [PATCH v5 7/9] pci/shpc: convert SHPC hotplug to use hotplug-handler API, Igor Mammedov, 2014/02/03
[Qemu-devel] [PATCH v5 6/9] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API, Igor Mammedov, 2014/02/03