Re: [Qemu-devel] [Qemu-trivial] [PATCH] ide: cmd_exec_dev_diagnostic() always set error register to 0x01

[Michael Tokarev]

15.01.2014 20:15, Michael Tokarev wrote:
> 25.12.2013 18:17, David du Colombier wrote:
>> This notably fix IDE CD probing on the Plan 9 operating system,
>> which rely on the error register set by the Execute Device
>> Diagnostic command to detect drive configurations.
> 
> While this is a one-liner, I'm not sure it is "trivial enough", just because
> it is not at all obvious we shuold clear error here and not somewhere else.
> I mean, shouldn't s->error be cleared somewhere when next request is queued,
> or something like that?
> 
> That's basically why I haven't applied this initially.
> 
> CC'ing qemu-devel.

I've applied this to qemu-trivial 3 weeks ago, and now this change has been
applied to the master branch, -- still without any additional comments, which
is somewhat troubling me, but here we go.

Thanks,

/mjt