[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger t
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size |
Date: |
Thu, 30 Jan 2014 18:45:56 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Orit Wasserman (address@hidden) wrote:
> Signed-off-by: Orit Wasserman <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/migration.c b/migration.c
> index 46a7305..25add6f 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error
> **errp)
> return;
> }
>
> + /* Cache should not be larger than guest ram size */
> + if (value > ram_bytes_total()) {
> + error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size",
> + "exceeds guest ram size ");
> + return;
> + }
> +
> new_size = xbzrle_cache_resize(value);
> if (new_size < 0) {
> error_set(errp, QERR_INVALID_PARAMETER_VALUE, "cache size",
> --
> 1.8.3.1
>
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Qemu-devel] [PATCH v2 3/6] migration:fix free XBZRLE decoded_buf wrong, Orit Wasserman, 2014/01/30
[Qemu-devel] [PATCH v2 5/6] Don't abort on out of memory when creating page cache, Orit Wasserman, 2014/01/30
[Qemu-devel] [PATCH v2 6/6] Don't abort on memory allocation error, Orit Wasserman, 2014/01/30