qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] hw/scsi/megasas.c: (sdev->id & 0xFF) >> 8


From: Markus Armbruster
Subject: [Qemu-devel] hw/scsi/megasas.c: (sdev->id & 0xFF) >> 8
Date: Thu, 30 Jan 2014 16:49:04 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

There are several instances of

    ((sdev->id & 0xFF) >> 8) | (sdev->lun & 0xFF)

or similar.  The left operand of | is always 0.  Did you intend to shift
to the other right?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]