[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-iotests: only run 071 on qcow2 |
Date: |
Wed, 29 Jan 2014 16:46:57 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Le Wednesday 29 Jan 2014 à 16:33:54 (+0100), Stefan Hajnoczi a écrit :
> The 071 test is designed for IMGFMT=qcow2 because it uses the l2_load
> blkdebug event. Its output filtering also assumes that IMGFMT is not
> raw since 071.out contains "format=raw" but IMGFMT=raw would filter the
> output to "format=IMGFMT".
>
> Perhaps the test case can be rewritten to be more generic, but for now
> let's document that it was only supposed to work with qcow2.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
> tests/qemu-iotests/071 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/071 b/tests/qemu-iotests/071
> index 2a22546..dbc07c6 100755
> --- a/tests/qemu-iotests/071
> +++ b/tests/qemu-iotests/071
> @@ -38,7 +38,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
> . ./common.rc
> . ./common.filter
>
> -_supported_fmt generic
> +_supported_fmt qcow2
> _supported_proto generic
> _supported_os Linux
>
> --
> 1.8.5.3
>
>
Reviewed-by: Benoit Canet <address@hidden>