Re: [Qemu-devel] [PATCH v8 12/13] dump: make kdump-compressed format available for 'dump-guest-memory'

[Laszlo Ersek]

On 01/28/14 07:22, qiaonuohan wrote:
> Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed
> format. The command's usage:
> 
>   dump [-p] protocol [begin] [length] [format]
> 
> 'format' is used to specified the format of vmcore and can be:
> 1. 'elf': ELF format, without compression
> 2. 'kdump-zlib': kdump-compressed format, with zlib-compressed
> 3. 'kdump-lzo': kdump-compressed format, with lzo-compressed
> 4. 'kdump-snappy': kdump-compressed format, with snappy-compressed
> Without 'format' being set, it is same as 'elf'. And if non-elf format is
> specified, paging and filter is not allowed.
> 
> Note:
>   1. The kdump-compressed format is readable only with the crash utility and
>      makedumpfile, and it can be smaller than the ELF format because of the
>      compression support.
>   2. The kdump-compressed format is the 6th edition.
> 
> Signed-off-by: Qiao Nuohan <address@hidden>
> ---
>  dump.c           |  131 
> +++++++++++++++++++++++++++++++++++++++++++++++++++---
>  hmp.c            |    5 ++-
>  qapi-schema.json |   25 ++++++++++-
>  qmp-commands.hx  |    7 ++-
>  4 files changed, 158 insertions(+), 10 deletions(-)

Reviewed-by: Laszlo Ersek <address@hidden>