Re: [Qemu-devel] [PATCH 07/10] block: Reuse fail path from bdrv_open()

[Kevin Wolf]

Am 26.01.2014 um 20:02 hat Max Reitz geschrieben:
> The fail paths of bdrv_file_open() and bdrv_open() naturally exhibit
> similarities, thus it is possible to reuse the one from bdrv_open() and
> shorten the one in bdrv_file_open() accordingly.
> 
> Signed-off-by: Max Reitz <address@hidden>

I find this change confusing because it is bdrv_file_open() that
takes ownership of bs->options and assigns it. So I think it should be
bdrv_file_open() that frees it again in failure cases.

Kevin