[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 14/35] acpi unit-test: resolved iasl crash
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL v2 14/35] acpi unit-test: resolved iasl crash |
Date: |
Sun, 26 Jan 2014 18:05:59 +0200 |
From: Marcel Apfelbaum <address@hidden>
It seems that iasl has an issue when disassembles
some ACPI tables using the command line:
iasl -e DSDT -e SSDT -d HPET
Modified the iasl command line to "iasl -d HPET"
until the problem is solved. The command line
remained the same for DSDT and SSDT tables.
Reported-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
tests/acpi-test.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/tests/acpi-test.c b/tests/acpi-test.c
index a3d2b34..6095d07 100644
--- a/tests/acpi-test.c
+++ b/tests/acpi-test.c
@@ -23,6 +23,7 @@
#define MACHINE_Q35 "q35"
#define ACPI_REBUILD_EXPECTED_AML "TEST_ACPI_REBUILD_AML"
+#define ACPI_SSDT_SIGNATURE 0x54445353 /* SSDT */
/* DSDT and SSDTs format */
typedef struct {
@@ -403,6 +404,11 @@ static void dump_aml_files(test_data *data, bool rebuild)
}
}
+static bool compare_signature(AcpiSdtTable *sdt, uint32_t signature)
+{
+ return sdt->header.signature == signature;
+}
+
static void load_asl(GArray *sdts, AcpiSdtTable *sdt)
{
AcpiSdtTable *temp;
@@ -419,9 +425,15 @@ static void load_asl(GArray *sdts, AcpiSdtTable *sdt)
/* build command line */
g_string_append_printf(command_line, " -p %s ", sdt->asl_file);
- for (i = 0; i < 2; ++i) { /* reference DSDT and SSDT */
- temp = &g_array_index(sdts, AcpiSdtTable, i);
- g_string_append_printf(command_line, "-e %s ", temp->aml_file);
+ if (compare_signature(sdt, ACPI_DSDT_SIGNATURE) ||
+ compare_signature(sdt, ACPI_SSDT_SIGNATURE)) {
+ for (i = 0; i < sdts->len; ++i) {
+ temp = &g_array_index(sdts, AcpiSdtTable, i);
+ if (compare_signature(temp, ACPI_DSDT_SIGNATURE) ||
+ compare_signature(temp, ACPI_SSDT_SIGNATURE)) {
+ g_string_append_printf(command_line, "-e %s ", temp->aml_file);
+ }
+ }
}
g_string_append_printf(command_line, "-d %s", sdt->aml_file);
--
MST
- [Qemu-devel] [PULL v2 04/35] virtio: Fix return value for dummy function vhost_net_virtqueue_pending, (continued)
- [Qemu-devel] [PULL v2 04/35] virtio: Fix return value for dummy function vhost_net_virtqueue_pending, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 05/35] acpi unit-test: add test files, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 06/35] configure: added acpi unit-test files, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 07/35] acpi unit-test: compare DSDT and SSDT tables against expected values, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 08/35] configure: add CONFIG_IASL to config-host.h, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 10/35] acpi unit-test: added script to rebuild the expected aml files, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 09/35] acpi unit-test: extract iasl executable from configuration, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 11/35] acpi unit-test: hook to rebuild expected aml files, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 12/35] tests: fix acpi to work on bigendian host, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 13/35] acpi unit-test: renamed ssdt_tables to tables, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 14/35] acpi unit-test: resolved iasl crash,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL v2 16/35] pc: make: fix dependencies: rebuild when included file is changed, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 15/35] acpi unit-test: do not fail on asl mismatch, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 17/35] pci: add pci_for_each_bus_depth_first, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 18/35] pcihp: generalization of piix4 acpi, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 19/35] piix4: add acpi pci hotplug support, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 20/35] acpi-build: enable hotplug for PCI bridges, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 21/35] acpi: factor out common cpu hotplug code for PIIX4/Q35, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 22/35] acpi: ich9: add CPU hotplug handling to Q35 machine, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 23/35] pc: set PRST base in DSDT depending on chipset, Michael S. Tsirkin, 2014/01/26
- [Qemu-devel] [PULL v2 24/35] pc: PIIX DSDT: exclude CPU/PCI hotplug & GPE0 IO range from PCI bus resources, Michael S. Tsirkin, 2014/01/26