[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immed
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immediate |
Date: |
Thu, 23 Jan 2014 20:11:44 +0000 |
On 23 January 2014 20:08, C Fontana <address@hidden> wrote:
>> + if (extended_result) {
>> + tcg_temp_free(tcg_src_hi);
>
>
>
> should this be tcg_temp_free_i64 ?
Yes, though it doesn't actually make a difference here
since we know we're building a 64 bit target QEMU.
>> + return;
>
>
> no harm but maybe remove return?
Agreed, and again on the second one.
thanks
-- PMM
- Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: Add SIMD three-different multiply accumulate insns, (continued)
- [Qemu-devel] [PATCH v2 4/8] target-arm: A64: Add top level decode for SIMD 3-same group, Peter Maydell, 2014/01/23
- [Qemu-devel] [PATCH v2 6/8] target-arm: A64: Add integer ops from SIMD 3-same group, Peter Maydell, 2014/01/23
- [Qemu-devel] [PATCH v2 2/8] target-arm: A64: Add SIMD three-different ABDL instructions, Peter Maydell, 2014/01/23
- [Qemu-devel] [PATCH v2 5/8] target-arm: A64: Add logic ops from SIMD 3 same group, Peter Maydell, 2014/01/23
- [Qemu-devel] [PATCH v2 3/8] target-arm: A64: Add SIMD scalar 3 same add, sub and compare ops, Peter Maydell, 2014/01/23
- [Qemu-devel] [PATCH v2 8/8] target-arm: A64: Add SIMD shift by immediate, Peter Maydell, 2014/01/23
- [Qemu-devel] [PATCH v2 7/8] target-arm: A64: Add simple SIMD 3-same floating point ops, Peter Maydell, 2014/01/23