Re: [Qemu-devel] [PATCH V7 3/6] qemu-iotests: add 058 internal snapshot export with qemu-nbd case

[Wenchao Xia]

于 2014/1/16 20:52, Kevin Wolf 写道:
> Am 04.12.2013 um 10:10 hat Wenchao Xia geschrieben:
> > This case can't run when IMGPROTO=nbd, since it needs to create some
> > internal snapshot which would fail for EOF write request, even when
> > TEST_IMG is exported with "-f raw" in common.rc, so set _supported_proto
> > to file.
> >
> > _require_command() is changed to tip what util is missing, instead
> > of printing a blank.
> >
> > Signed-off-by: Wenchao Xia <address@hidden>
>
> > --- a/tests/qemu-iotests/group
> > +++ b/tests/qemu-iotests/group
> > @@ -64,6 +64,7 @@
> >   055 rw auto
> >   056 rw auto backing
> >   057 rw auto
> > +058 rw auto
> >   059 rw auto
> >   060 rw auto
> >   061 rw auto
>
> Please, please, please, stop doing this.
>
> If you see a hole in the numbering of test cases, it is because there
> are yet unmerged patches that use this number. The only thing you
> achieve by filling up the hole is merge conflicts. I have branches that
> regularly require manual conflict resolution because people think they
> are clever when they fill up holes.
>
> Simply add your cases to the end of the file, okay? (And up to 078 is
> taken now, if someone needs to assign a new test number for his patch.)
>
> Kevin
  058 is the last number when I patched v1 if I didn't miss patch on
list, but you are right whole in number shouldn't be filled by new
patch.