[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec: Exclude non portable funct
|
From: |
Stefan Weil |
|
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] exec: Exclude non portable function for MinGW |
|
Date: |
Tue, 14 Jan 2014 18:40:03 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Am 14.01.2014 18:26, schrieb Michael Tokarev:
> 14.01.2014 10:00, Stefan Weil wrote:
>> cpu_physical_memory_set_dirty_lebitmap calls getpageaddr and ffsl which are
>> unavailable for MinGW. As the function is unused for MinGW, it can simply
>> be excluded from compilation.
> I applied it to -trivial. But maybe it's better to just move whole thing to
> kvm-all.c where
> it is actually used?
>
> Thanks,
>
> /mjt
That's a good suggestion.
Juan, a comment in include/exec/ram_addr.h says that those functions
will be removed soon. Would you suggest moving them to kvm-all.c now, or
would you prefer the conditional compilation for MinGW which I
introduced with my patch?
Regards,
Stefan