[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 41/49] memory: cpu_physical_memory_set_dirty_trackin
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 41/49] memory: cpu_physical_memory_set_dirty_tracking() should return void |
Date: |
Mon, 13 Jan 2014 18:40:26 +0100 |
Result was always 0, and not used anywhere. Once there, use bool type
for the parameter.
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Orit Wasserman <address@hidden>
---
exec.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/exec.c b/exec.c
index c71f2d5..514d6a0 100644
--- a/exec.c
+++ b/exec.c
@@ -57,7 +57,7 @@
//#define DEBUG_SUBPAGE
#if !defined(CONFIG_USER_ONLY)
-static int in_migration;
+static bool in_migration;
RAMList ram_list = { .blocks = QTAILQ_HEAD_INITIALIZER(ram_list.blocks) };
@@ -752,11 +752,9 @@ void cpu_physical_memory_reset_dirty(ram_addr_t start,
ram_addr_t length,
}
}
-static int cpu_physical_memory_set_dirty_tracking(int enable)
+static void cpu_physical_memory_set_dirty_tracking(bool enable)
{
- int ret = 0;
in_migration = enable;
- return ret;
}
hwaddr memory_region_section_get_iotlb(CPUArchState *env,
@@ -1798,12 +1796,12 @@ static void tcg_commit(MemoryListener *listener)
static void core_log_global_start(MemoryListener *listener)
{
- cpu_physical_memory_set_dirty_tracking(1);
+ cpu_physical_memory_set_dirty_tracking(true);
}
static void core_log_global_stop(MemoryListener *listener)
{
- cpu_physical_memory_set_dirty_tracking(0);
+ cpu_physical_memory_set_dirty_tracking(false);
}
static MemoryListener core_memory_listener = {
--
1.8.4.2
- [Qemu-devel] [PATCH 31/49] memory: unfold cpu_physical_memory_set_dirty() in its only user, (continued)
- [Qemu-devel] [PATCH 31/49] memory: unfold cpu_physical_memory_set_dirty() in its only user, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 29/49] memory: split dirty bitmap into three, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 33/49] memory: make cpu_physical_memory_get_dirty() the main function, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 32/49] memory: unfold cpu_physical_memory_set_dirty_flag(), Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 35/49] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 34/49] memory: cpu_physical_memory_get_dirty() is used as returning a bool, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 36/49] memory: use find_next_bit() to find dirty bits, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 38/49] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 39/49] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty(), Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 37/49] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 41/49] memory: cpu_physical_memory_set_dirty_tracking() should return void,
Juan Quintela <=
- [Qemu-devel] [PATCH 42/49] memory: split cpu_physical_memory_* functions to its own include, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 43/49] memory: unfold memory_region_test_and_clear(), Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 40/49] memory: make cpu_physical_memory_reset_dirty() take a length parameter, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 44/49] kvm: use directly cpu_physical_memory_* api for tracking dirty pages, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 45/49] kvm: refactor start address calculation, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 46/49] memory: move bitmap synchronization to its own function, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 48/49] ram: split function that synchronizes a range, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 49/49] migration: synchronize memory bitmap 64bits at a time, Juan Quintela, 2014/01/13
- [Qemu-devel] [PATCH 47/49] memory: syncronize kvm bitmap using bitmaps operations, Juan Quintela, 2014/01/13