[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-pr
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags |
Date: |
Mon, 13 Jan 2014 12:53:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 11/01/2014 08:46, Stefan Weil ha scritto:
> Hi Steven,
>
> --disable-stack-protector would also be useful for platforms which make
> debugging of executables with stack protection difficult. When I must
> debug Windows executables, I always disable stack protection, because
> otherwise the stack back traces are unreadable.
>
> So, for MinGW it might be reasonable to set the default to no stack
> protection if --enable-debug is selected. This requires some
> modifications in your patch.
>
> # Don't set it to "yes" initially:
> stack_protector=""
>
> # Do the compile test if it is not "no":
> if test "$stack_protector" != "no"; then
Apart from this little detail, the patch looks good.
Steven, please resend the patch as a top-level message with the patch
inline rather than attached. This is needed so that Anthony's script
will pick it up. Including these changes would be nice too.
Paolo
> The usual logic is do nothing if the user says "no". Run the compile
> tests otherwise. Show an error message if the compile tests fail and the
> user said "yes". See the code which handles $pie for an example.
>
> Please send your next patch inline - this makes it easier to add comments.
>
> Best regards
>
> Stefan
>
- [Qemu-devel] [PATCH 3/3] Makefile: add bios-256k.bin to BLOBS, (continued)
- Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags, Peter Maydell, 2014/01/09
- Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags, Paolo Bonzini, 2014/01/09
- Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags, Brad Smith, 2014/01/09
- Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags, Noonan, Steven, 2014/01/10
- Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags, Noonan, Steven, 2014/01/10
- Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags, Stefan Weil, 2014/01/11
- Re: [Qemu-devel] [PATCH 1/3] configure: add option to disable -fstack-protector flags,
Paolo Bonzini <=
- [Qemu-devel] [PATCH] configure: add option to disable -fstack-protector flags, Steven Noonan, 2014/01/13
- Re: [Qemu-devel] [PATCH] configure: add option to disable -fstack-protector flags, Stefan Weil, 2014/01/13
- Re: [Qemu-devel] [PATCH] configure: add option to disable -fstack-protector flags, Noonan, Steven, 2014/01/13