[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/13] mxs/imx23: Add digctl driver
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH 06/13] mxs/imx23: Add digctl driver |
Date: |
Sat, 11 Jan 2014 18:44:24 +1000 |
On Thu, Jan 9, 2014 at 4:55 AM, Peter Maydell <address@hidden> wrote:
> On 8 January 2014 18:39, M P <address@hidden> wrote:
>> I will re-add the trace for both write and read and see if I can narrow the
>> range down; it will be linux specific, tho, that's why I thought a
>> 'catchall' block was more appropriate.
I would suggest you do the ones you care about properly, and
RAZ/WI+qemu_log_mask(LOG_UNIMP, the rest. When it comes to the
unimplemented, hard obvious failure from a totally unresponsive
register is preferrable to subtle infidelities (like being able to
write to RO register).
Regards,
Peter
>
> Well, we should be implementing what the hardware does,
> generally. Misimplementing things as "read as written"
> isn't really any better than misimplementing them as
> RAZ/WI, it's just differently wrong.
>
> thanks
> -- PMM
>