qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_bina


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH] linux-user: Remove regs parameter load_elf_binary and load_flt_binary
Date: Thu, 09 Jan 2014 13:03:06 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

"... of load_elf_binary() and load_flt_binary()" - Riku can you fix pls?

Am 09.01.2014 10:10, schrieb Will Newton:
> The regs parameter is not used anywhere, so remove it.
> 
> Signed-off-by: Will Newton <address@hidden>
> ---
>  linux-user/elfload.c   | 3 +--
>  linux-user/flatload.c  | 3 +--
>  linux-user/linuxload.c | 4 ++--
>  linux-user/qemu.h      | 6 ++----
>  4 files changed, 6 insertions(+), 10 deletions(-)

Please CC your colleague as the maintainer, scripts/get_maintainer.pl
--nogit-fallback can help automate that.
Also you probably wanted address@hidden, too. ;)

That said, patch contents look fine, without knowing the history,

Reviewed-by: Andreas Färber <address@hidden>

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]