Re: [Qemu-devel] [PATCH 1/2] scripts/qemu-binfmt-conf.sh: re-factor and clean-up

[Andreas Färber]

Hi,

Am 08.01.2014 15:25, schrieb address@hidden:
> From: Alex Bennée <address@hidden>
> 
> I was looking to set-up for development but found the script made some
> hard-coded assumptions. It doesn't seem the script is used by the
> distros but if it had a little more love maybe it would be ;-)
> 
> * Add usage() instructions
> * Move all registering to a single function
> * Check for existence of executable qemu before registering
> * Add -d (devel) mode for subscribing in-src tree binaries
> * error handling when setting binfmt fails
> * add support for aarch64
> ---
>  scripts/qemu-binfmt-conf.sh | 124 
> +++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 105 insertions(+), 19 deletions(-)
>  mode change 100644 => 100755 scripts/qemu-binfmt-conf.sh

Apart from both patches missing a Sob, did you take a look at the
refactoring we discussed with Laurent Vivier (?) a while back?

Essentially, there's multiple ways to register this, and based on our
feedback he refactored it so that the magic strings can be retrieved
individually. Don't remember where that got stuck...

Regards
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg