Re: [Qemu-devel] [PATCH v4 1/1] qtest: Fix the bug about disable vnc causes "make check" fail

[Kevin Wolf]

Am 07.01.2014 um 15:41 hat Paolo Bonzini geschrieben:
> Il 06/01/2014 07:05, Kewei Yu ha scritto:
> > When we disable vnc from "./configure", QEMU can't use the vnc option.
> > So qtest can't use the "vnc -none ", otherwise "make check" fails.
> > If QEMU uses "-display none", "-vnc none" is excrescent, So we just need to 
> > drop it.
> > 
> > Signed-off-by: Kewei Yu <address@hidden>
> > ---
> >  v2: Consolidate VNC macro's #ifdef'ery to one central point 
> > (tests/libqtest.c).
> >  v3: Fix the spelling and terminology error: "s/disabling/disable; s/the\ 
> > qemu/QEMU; s/hangs/fails;"
> >  v4: If QEMU uses "-display none", "-vnc none" is excrescent, So we just 
> > need to drop it.
> 
> Reviewed-by: Paolo Bonzini <address@hidden>

Thanks, applied to the block branch.

Kevin