qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/1] qtest:Fix the bug about disabling vnc cause


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 1/1] qtest:Fix the bug about disabling vnc causes "make check" hang
Date: Tue, 07 Jan 2014 11:35:27 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Stefan Hajnoczi <address@hidden> writes:

> On Tue, Dec 31, 2013 at 01:19:02AM +0100, Andreas Färber wrote:
>> Am 30.12.2013 09:46, schrieb Kewei Yu:
>> > When we disabling vnc from "./configure", the qemu can't use the vnc 
>> > option.
>> > So qtest can't use the "vnc -none ", otherwise "make check" will hang.
>> > 
>> > Signed-off-by: Kewei Yu <address@hidden>
>> > ---
>> >  tests/fdc-test.c |    4 ++++
>> >  tests/ide-test.c |   11 ++++++++---
>> >  2 files changed, 12 insertions(+), 3 deletions(-)
>> > 
>> > diff --git a/tests/fdc-test.c b/tests/fdc-test.c
>> > index 38b5b17..80dbdfb 100644
>> > --- a/tests/fdc-test.c
>> > +++ b/tests/fdc-test.c
>> > @@ -538,7 +538,11 @@ int main(int argc, char **argv)
>> >      /* Run the tests */
>> >      g_test_init(&argc, &argv, NULL);
>> >  
>> > +#ifdef CONFIG_VNC
>> >      cmdline = g_strdup_printf("-vnc none ");
>> > +#else
>> > +    cmdline = NULL;
>> > +#endif
>> >  
>> >      qtest_start(cmdline);
>> >      qtest_irq_intercept_in(global_qtest, "ioapic");
>> 
>> I have already made -display none a default used by all qtests.
>> http://git.qemu.org/?p=qemu.git;a=commit;h=2ad645d2854746b55ddfd1d8e951f689cca5d78f
>> 
>> Is there a reason not to do the same for -vnc none?
>> That would consolidate the #ifdef'ery to one central point.
>
> Agreed, let's set -vnc none by default in one place (if enabled by
> ./configure).
>
> I wonder if we should use -nodefaults too?  That may require adding some
> new options to explicitly set up devices used by existing tests.

Try and see what explodes?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]