qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/10] target-arm: A64: Add support for dumping


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 01/10] target-arm: A64: Add support for dumping AArch64 VFP register state
Date: Mon, 30 Dec 2013 15:21:17 +0000

On 30 December 2013 14:58, Richard Henderson <address@hidden> wrote:
> On 12/28/2013 01:49 PM, Peter Maydell wrote:
>> +            uint64_t vlo = float64_val(env->vfp.regs[i * 2]);
>> +            uint64_t vhi = float64_val(env->vfp.regs[(i * 2) + 1]);
>> +            cpu_fprintf(f, "q%02d.0=%016" PRIx64 ":%016" PRIx64 " ",
>> +                        i, vlo, vhi);
>
> Why print them lo:hi instead of, what would seem to me, the more natural 
> hi:lo.

Whoops, didn't read this patch quite closely enough :-)

> And what's that .0 qualifier doing on the end of an integer print field?

May be poorly edited remnant from a previous labelling of the two
halves as x.0 and x.1. Will remove.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]