Re: [Qemu-devel] [V4 PATCH 18/22] target-ppc: Add VSX xmax/xmin Instructions

[Richard Henderson]

On 12/18/2013 12:19 PM, Tom Musta wrote:
> +        if (unlikely(tp##_is_any_nan(xa.fld[i]) ||                           
>  \
> +                     tp##_is_any_nan(xb.fld[i]))) {                          
>  \
> +            if (tp##_is_signaling_nan(xa.fld[i])) {                          
>  \
> +                xt.fld[i] = tp##_snan_to_qnan(xa.fld[i]);                    
>  \
> +                fload_invalid_op_excp(env, POWERPC_EXCP_FP_VXSNAN, 0);       
>  \
> +            } else if (tp##_is_signaling_nan(xb.fld[i])) {                   
>  \
> +                xt.fld[i] = tp##_snan_to_qnan(xb.fld[i]);                    
>  \
> +                fload_invalid_op_excp(env, POWERPC_EXCP_FP_VXSNAN, 0);       
>  \
> +            } else if (tp##_is_quiet_nan(xb.fld[i])) {                       
>  \
> +                xt.fld[i] = xa.fld[i];                                       
>  \
> +            } else { /* XA is QNaN */                                        
>  \
> +                xt.fld[i] = xb.fld[i];                                       
>  \
> +            }                                                                
>  \
> +        } else {                                                             
>  \
> +            xt.fld[i] = tp##_##op(xa.fld[i], xb.fld[i], &env->fp_status);    
>  \
> +        }                                                                    
>  \

We have minnum/maxnum now.


r~