[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] arm64: Set source for ret instruction correctly
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] arm64: Set source for ret instruction correctly. |
Date: |
Mon, 23 Dec 2013 22:17:15 +0000 |
On 23 December 2013 22:00, Richard W.M. Jones <address@hidden> wrote:
> From: "Richard W.M. Jones" <address@hidden>
>
> Fixes https://bugs.launchpad.net/qemu/+bug/1263747
>
> Signed-off-by: Richard W.M. Jones <address@hidden>
> Tested-by: Richard W.M. Jones <address@hidden>
> ---
I'm guessing this is against the SuSE tree? Probably best to
say so specifically, because this code is different in mainline.
CC'ing Alex who might also care about SuSE tree fixes.
> target-arm/translate-a64.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 36ebb0f..29454b0 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -273,7 +273,6 @@ static void handle_br(DisasContext *s, uint32_t insn)
> tcg_gen_movi_i64(cpu_reg(30), s->pc);
> break;
> case 2: /* RET */
> - source = 30;
> break;
> case 3:
> unallocated_encoding(s);
> --
> 1.8.3.1
>
FWIW mainline's handling of this insn doesn't have this bug.
thanks
-- PMM