[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V7 1/6] snapshot: add parameter *errp in snapsho
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V7 1/6] snapshot: add parameter *errp in snapshot create |
Date: |
Fri, 20 Dec 2013 15:26:25 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 05, 2013 at 08:02:47PM +0800, Wenchao Xia wrote:
> @@ -366,7 +368,8 @@ int qcow2_snapshot_create(BlockDriverState *bs,
> QEMUSnapshotInfo *sn_info)
>
> /* Check that the ID is unique */
> if (find_snapshot_by_id_and_name(bs, sn_info->id_str, NULL) >= 0) {
> - return -EEXIST;
> + error_setg(errp, "Snapshot with id %s already exist",
> sn_info->id_str);
s/exist/exists/