[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant |
Date: |
Fri, 20 Dec 2013 12:13:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
Am 19.12.2013 15:30, schrieb address@hidden:
> From: Markus Armbruster <address@hidden>
>
> Once upon a time, the error message was:
>
> qemu: -device nonexistant: "Device "nonexistant" not found. Try -device
> '?' for a list.
>
> But progress marches on, and conversion to QError (commit 0204276)
> changed it into:
>
> Invalid parameter 'driver'
> Try with argument '?' for a list.
>
> Progress didn't stop there, of course. After a couple of iterations,
> we arrived at the current message (commit 6acbe4c):
>
> qemu: -device nonexistant: Parameter 'driver' expects device type
>
> Mission accomplished: this is complete mush.
>
> We've since abandoned our quest for "rich" error objects, fortunately
> before it turned all error messages into mush. Time to undo the
> damage to this one. Make it:
>
> qemu: -device nonexistant: nonexistant is not a valid device model name
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qdev-monitor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks, rebased onto your other fix and applied to qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg