|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 13/21] target-arm: A64: Implement MRS/MSR/SYS/SYSL |
Date: | Thu, 19 Dec 2013 12:30:50 -0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/17/2013 07:12 AM, Peter Maydell wrote: > +/* Force a TB lookup after an instruction that changes the CPU state */ > +static inline void gen_lookup_tb(DisasContext *s) > +{ > + gen_a64_set_pc_im(s->pc); > + s->is_jmp = DISAS_UPDATE; > +} > + I'm a bit surprised that this set_pc doesn't happen in gen_intermediate_code_internal_a64. Otherwise, what's the point in distinguishing between DISAS_JUMP and DISAS_UPDATE? Otherwise, Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |