Re: [Qemu-devel] [PATCH 13/21] target-arm: A64: Implement MRS/MSR/SYS/SYSL

[Richard Henderson]

On 12/17/2013 07:12 AM, Peter Maydell wrote:
> +/* Force a TB lookup after an instruction that changes the CPU state */
> +static inline void gen_lookup_tb(DisasContext *s)
> +{
> +    gen_a64_set_pc_im(s->pc);
> +    s->is_jmp = DISAS_UPDATE;
> +}
> +

I'm a bit surprised that this set_pc doesn't happen in
gen_intermediate_code_internal_a64.  Otherwise, what's the point in
distinguishing between DISAS_JUMP and DISAS_UPDATE?

Otherwise,

Reviewed-by: Richard Henderson <address@hidden>


r~