|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH 01/21] target-arm: A64: add support for ld/st pair |
| Date: | Thu, 19 Dec 2013 08:58:49 -0800 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/17/2013 07:12 AM, Peter Maydell wrote:
> + TCGMemOp memop = MO_TE + size;
Watch the double space (multiple occurrences).
> + if (is_vector) {
> + if (opc == 3) {
> + unallocated_encoding(s);
> + return;
> + }
In the integer LDP description I see
if L:opc<0> == '01' || opc == '11' then UnallocatedEncoding();
I think that opc == 3 check should be hoisted outside is_vector.
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |