Re: [Qemu-devel] [PATCH 33/38] kvm: refactor start address calculation

[Orit Wasserman]

On 12/17/2013 05:26 PM, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>   kvm-all.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 308dfba..cb62ba4 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -382,7 +382,8 @@ static int 
> kvm_get_dirty_pages_log_range(MemoryRegionSection *section,
>   {
>       unsigned int i, j;
>       unsigned long page_number, c;
> -    hwaddr addr, addr1;
> +    hwaddr addr;
> +    ram_addr_t start = section->offset_within_region + section->mr->ram_addr;
>       ram_addr_t ram_addr;
>       unsigned int pages = int128_get64(section->size) / getpagesize();
>       unsigned int len = (pages + HOST_LONG_BITS - 1) / HOST_LONG_BITS;
> @@ -399,9 +400,8 @@ static int 
> kvm_get_dirty_pages_log_range(MemoryRegionSection *section,
>                   j = ffsl(c) - 1;
>                   c &= ~(1ul << j);
>                   page_number = (i * HOST_LONG_BITS + j) * hpratio;
> -                addr1 = page_number * TARGET_PAGE_SIZE;
> -                addr = section->offset_within_region + addr1;
> -                ram_addr = section->mr->ram_addr + addr;
> +                addr = page_number * TARGET_PAGE_SIZE;
> +                ram_addr = start + addr;
>                   cpu_physical_memory_set_dirty_range(ram_addr,
>                                                       TARGET_PAGE_SIZE * 
> hpratio);
>               } while (c != 0);

Reviewed-by: Orit Wasserman <address@hidden>