qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* a


From: Orit Wasserman
Subject: Re: [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* api for tracking dirty pages
Date: Thu, 19 Dec 2013 12:03:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 12/17/2013 05:26 PM, Juan Quintela wrote:
Performance is important in this function, and we want to optimize even further.

Signed-off-by: Juan Quintela <address@hidden>
---
  kvm-all.c | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/kvm-all.c b/kvm-all.c
index 3937754..308dfba 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -31,6 +31,7 @@
  #include "sysemu/kvm.h"
  #include "qemu/bswap.h"
  #include "exec/memory.h"
+#include "exec/ram_addr.h"
  #include "exec/address-spaces.h"
  #include "qemu/event_notifier.h"
  #include "trace.h"
@@ -382,6 +383,7 @@ static int 
kvm_get_dirty_pages_log_range(MemoryRegionSection *section,
      unsigned int i, j;
      unsigned long page_number, c;
      hwaddr addr, addr1;
+    ram_addr_t ram_addr;
      unsigned int pages = int128_get64(section->size) / getpagesize();
      unsigned int len = (pages + HOST_LONG_BITS - 1) / HOST_LONG_BITS;
      unsigned long hpratio = getpagesize() / TARGET_PAGE_SIZE;
@@ -399,8 +401,9 @@ static int 
kvm_get_dirty_pages_log_range(MemoryRegionSection *section,
                  page_number = (i * HOST_LONG_BITS + j) * hpratio;
                  addr1 = page_number * TARGET_PAGE_SIZE;
                  addr = section->offset_within_region + addr1;
-                memory_region_set_dirty(section->mr, addr,
-                                        TARGET_PAGE_SIZE * hpratio);
+                ram_addr = section->mr->ram_addr + addr;
+                cpu_physical_memory_set_dirty_range(ram_addr,
+                                                    TARGET_PAGE_SIZE * 
hpratio);
              } while (c != 0);
          }
      }


Reviewed-by: Orit Wasserman <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]