[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone su
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone support |
Date: |
Thu, 19 Dec 2013 14:56:22 +1000 |
On Wed, Dec 4, 2013 at 10:48 PM, Fedorov Sergey <address@hidden> wrote:
>
> On 12/04/2013 03:13 PM, Peter Maydell wrote:
>>
>> On 4 December 2013 10:08, Fedorov Sergey <address@hidden> wrote:
>>>
>>> On 12/03/2013 12:48 PM, Sergey Fedorov wrote:
>>>>
>>>> This patch set implements a basic support of CPU core TrustZone feature.
>>>
>>> We'd like this patch series finally to be merged into mainstream. What
>>> should be done to achieve this goal?
>>
>> I'd like to see TZ support in mainline too.
>
>
> That is the most important for me now :-) So I will try these patches to get
> shape suitable for mainline. Thanks!
>
>
>> The high level answer
>> is that it needs to get code reviewed, and you need to fix issues
>> that are raised in code review.
I'm done with first round review here - sorry about the delay. Mostly
trivials but two bigger points:
1: The name "Trustzone" does not match ARM doco which uses "security extensions"
2: I think that banking scheme where you maintain active copies is a
bit awkward.
Regards,
Peter
>> Unfortunately my review queue is
>> currently pretty full (it has Allwinner board support, DIGIC board
>> support, a bunch of Cadence fixes, ARMv8 32 bit new instructions
>> and the A64 64 bit instruction support in it, all of which are fairly
>> big patchsets), so it may take me a little while to get to this
>> patchset. It is on my todo list though, so it won't get forgotten :-)
>>
>> thanks
>> -- PMM
>>
>
> Best regards,
> Sergey Fedorov
>
- [Qemu-devel] [RFC PATCH 06/21] target-arm: add arm_is_secure() helper, (continued)
- [Qemu-devel] [RFC PATCH 06/21] target-arm: add arm_is_secure() helper, Sergey Fedorov, 2013/12/03
- [Qemu-devel] [RFC PATCH 20/21] target-arm: implement SMC instruction, Sergey Fedorov, 2013/12/03
- [Qemu-devel] [RFC PATCH 19/21] target-arm: add MVBAR support, Sergey Fedorov, 2013/12/03
- [Qemu-devel] [RFC PATCH 21/21] target-arm: implement IRQ/FIQ routing to Monitor mode, Sergey Fedorov, 2013/12/03
- Re: [Qemu-devel] [RFC PATCH 00/21] target-arm: add CPU core TrustZone support, Fedorov Sergey, 2013/12/04