Re: [Qemu-devel] [PATCH 09/18] softfloat: Fix Handling of Small Negatives in float64_to_uint64

[Tom Musta]

On 12/12/2013 6:13 PM, Peter Maydell wrote:
> On 9 December 2013 15:47, Tom Musta <address@hidden> wrote:
>> The float64_to_uint64 routine exits early for all negative numbers.
>> While the integer result is always correctly returned as 0, the
>> exception flags are also always set to float_flag_invalid.  This
>> is incorrect for those cases where a small negative number (-1 < x < 0)
>> rounds to zero.  In such a case, the flag should be reported as
>> inexact.
> 
>> -static int64 roundAndPackUint64(uint64_t absZ0, uint64_t absZ1 STATUS_PARAM)
>> +static int64 roundAndPackUint64(flag zSign, uint64_t absZ0,
>> +                                uint64_t absZ1 STATUS_PARAM)
> 
> This function isn't in the copy of fpu/softfloat.c that's in master,
> unless I'm confused. Does this series depend on something else?
> 
> thanks
> -- PMM
> 

Peter:  Yes, it does.  See 
http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg00045.html and 
specifically patch 1/19.