[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatte
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatten_qdict() |
Date: |
Fri, 13 Dec 2013 19:58:03 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
> delete is always set to true, therefore it can be removed.
>
> Signed-off-by: Max Reitz <address@hidden>
Nope, this can't be right.
delete is always set, except for simple types in the top-level QDict.
They get deleted now instead of being left alone.
But it coincides pretty well with the new loop condition. Leaving
uninteresting stuff aside, the loop looks now like this:
while (entry != NULL) {
...
entry = qdict_first(qdict);
}
So the loop only terminates when all elements have been removed. How
lucky we are that it really does remove all elements now!
Perhaps some other code is broken, or I missed something else, but
qemu-iotests 067 segfaults after this patch.
Kevin
- Re: [Qemu-devel] [PATCH v3 21/21] iotests: Test new blkdebug/blkverify interface, (continued)
- Re: [Qemu-devel] [PATCH v3 00/21] blkdebug/blkverify: Allow QMP configuration, Fam Zheng, 2013/12/12
- [Qemu-devel] [PATCH v3 00/21] blkdebug/blkverify: Allow QMP configuration, Max Reitz, 2013/12/13
- [Qemu-devel] [PATCH v5 06/22] qemu-option: Add qemu_config_parse_qdict(), Max Reitz, 2013/12/13
- [Qemu-devel] [PATCH v5 04/22] qapi: extend qdict_flatten() for QLists, Max Reitz, 2013/12/13
- [Qemu-devel] [PATCH v5 07/22] blkdebug: Always call read_config(), Max Reitz, 2013/12/13
- [Qemu-devel] [PATCH v5 08/22] blkdebug: Use command-line in read_config(), Max Reitz, 2013/12/13
- [Qemu-devel] [PATCH v5 09/22] block: Allow reference for bdrv_file_open(), Max Reitz, 2013/12/13