qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] issue with vgabios lfb and virtio vga


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] issue with vgabios lfb and virtio vga
Date: Fri, 13 Dec 2013 08:06:00 +0100

On Fr, 2013-12-13 at 11:58 +1000, Dave Airlie wrote:
> On Thu, Dec 12, 2013 at 6:17 PM, Gerd Hoffmann <address@hidden> wrote:
> > On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote:
> >> Now the vgabios.c does a check of bar 0 and bar 1 to see if they are
> >> 0xfff1 masked, this protects against the the i/o bar but fails to
> >> protect against the LFB one as PCI BARs don't encode the size just the
> >> base address, and a 4k BAR can be aligned to a larger size.
> >
> >> Any ideas? I seem to remember vgabios.c had a hack in the past for
> >> vmware, but I'm not sure.
> >
> > The fallback to bar #1 *is* the vmware hack ;)
> >
> > Something like the attached patch should do the trick.
> >
> Oh do we generate the VGABIOS from seabios now or are we going to?

master is switched to seavgabios, 1.7 still at the old one.

"git submodule init" will fetch firmware subtrees.
the Makefile in roms/ has targets to build vgabioses.

cheers,
  Gerd






reply via email to

[Prev in Thread] Current Thread [Next in Thread]