qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-lm32: Use new qemu_ld/st opcodes


From: Michael Walle
Subject: Re: [Qemu-devel] [PATCH] target-lm32: Use new qemu_ld/st opcodes
Date: Thu, 12 Dec 2013 23:18:59 +0100
User-agent: KMail/1.13.7 (Linux/3.2.0-4-686-pae; KDE/4.8.4; i686; ; )

Hi Richard,

Am Samstag, 7. Dezember 2013, 03:03:21 schrieb Richard Henderson:
> Cc: Michael Walle <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target-lm32/translate.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/target-lm32/translate.c b/target-lm32/translate.c
> index 6ea0ecd..3d2f2e8 100644
> --- a/target-lm32/translate.c
> +++ b/target-lm32/translate.c
> @@ -441,7 +441,7 @@ static void dec_lb(DisasContext *dc)
> 
>      t0 = tcg_temp_new();
>      tcg_gen_addi_tl(t0, cpu_R[dc->r0], sign_extend(dc->imm16, 16));
> -    tcg_gen_qemu_ld8s(cpu_R[dc->r1], t0, MEM_INDEX);
> +    tcg_gen_qemu_ld_tl(cpu_R[dc->r1], t0, MEM_INDEX, MO_SB);
>      tcg_temp_free(t0);
>  }
> 
> @@ -453,7 +453,7 @@ static void dec_lbu(DisasContext *dc)
> 
>      t0 = tcg_temp_new();
>      tcg_gen_addi_tl(t0, cpu_R[dc->r0], sign_extend(dc->imm16, 16));
> -    tcg_gen_qemu_ld8u(cpu_R[dc->r1], t0, MEM_INDEX);
> +    tcg_gen_qemu_ld_tl(cpu_R[dc->r1], t0, MEM_INDEX, MO_UB);
>      tcg_temp_free(t0);
>  }
> 
> @@ -465,7 +465,7 @@ static void dec_lh(DisasContext *dc)
> 
>      t0 = tcg_temp_new();
>      tcg_gen_addi_tl(t0, cpu_R[dc->r0], sign_extend(dc->imm16, 16));
> -    tcg_gen_qemu_ld16s(cpu_R[dc->r1], t0, MEM_INDEX);
> +    tcg_gen_qemu_ld_tl(cpu_R[dc->r1], t0, MEM_INDEX, MO_TESW);
>      tcg_temp_free(t0);
>  }
> 
> @@ -477,7 +477,7 @@ static void dec_lhu(DisasContext *dc)
> 
>      t0 = tcg_temp_new();
>      tcg_gen_addi_tl(t0, cpu_R[dc->r0], sign_extend(dc->imm16, 16));
> -    tcg_gen_qemu_ld16u(cpu_R[dc->r1], t0, MEM_INDEX);
> +    tcg_gen_qemu_ld_tl(cpu_R[dc->r1], t0, MEM_INDEX, MO_TEUW);
>      tcg_temp_free(t0);
>  }
> 
> @@ -489,7 +489,7 @@ static void dec_lw(DisasContext *dc)
> 
>      t0 = tcg_temp_new();
>      tcg_gen_addi_tl(t0, cpu_R[dc->r0], sign_extend(dc->imm16, 16));
> -    tcg_gen_qemu_ld32s(cpu_R[dc->r1], t0, MEM_INDEX);
> +    tcg_gen_qemu_ld_tl(cpu_R[dc->r1], t0, MEM_INDEX, MO_TEUL);

shouldn't this be MO_TESL?

>      tcg_temp_free(t0);
>  }
> 
> @@ -663,7 +663,7 @@ static void dec_sb(DisasContext *dc)
> 
>      t0 = tcg_temp_new();
>      tcg_gen_addi_tl(t0, cpu_R[dc->r0], sign_extend(dc->imm16, 16));
> -    tcg_gen_qemu_st8(cpu_R[dc->r1], t0, MEM_INDEX);
> +    tcg_gen_qemu_st_tl(cpu_R[dc->r1], t0, MEM_INDEX, MO_UB);
>      tcg_temp_free(t0);
>  }
> 
> @@ -697,7 +697,7 @@ static void dec_sh(DisasContext *dc)
> 
>      t0 = tcg_temp_new();
>      tcg_gen_addi_tl(t0, cpu_R[dc->r0], sign_extend(dc->imm16, 16));
> -    tcg_gen_qemu_st16(cpu_R[dc->r1], t0, MEM_INDEX);
> +    tcg_gen_qemu_st_tl(cpu_R[dc->r1], t0, MEM_INDEX, MO_TEUW);
>      tcg_temp_free(t0);
>  }
> 
> @@ -794,7 +794,7 @@ static void dec_sw(DisasContext *dc)
> 
>      t0 = tcg_temp_new();
>      tcg_gen_addi_tl(t0, cpu_R[dc->r0], sign_extend(dc->imm16, 16));
> -    tcg_gen_qemu_st32(cpu_R[dc->r1], t0, MEM_INDEX);
> +    tcg_gen_qemu_st_tl(cpu_R[dc->r1], t0, MEM_INDEX, MO_TEUL);
>      tcg_temp_free(t0);
>  }


-michael



reply via email to

[Prev in Thread] Current Thread [Next in Thread]