[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt co
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt controller |
Date: |
Thu, 12 Dec 2013 19:11:33 +0000 |
On 11 December 2013 08:08, liguang <address@hidden> wrote:
> +static void aw_a10_pic_set_irq(void *opaque, int irq, int level)
> +{
> + AwA10PICState *s = opaque;
> +
> + if (level) {
> + set_bit(irq%32, (void *)&s->irq_pending[irq/32]);
The % and / operators here should have spaces round them.
> + }
> + aw_a10_pic_update(s);
> +}
> +
> +static uint64_t aw_a10_pic_read(void *opaque, hwaddr offset, unsigned size)
> +{
> + AwA10PICState *s = opaque;
> + uint8_t index = (offset & 0xc)/4;
Spaces.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
-- PMM
- [Qemu-devel] [PATCH v11 0/5] add allwinner A10 SoC support, liguang, 2013/12/11
- [Qemu-devel] [PATCH v11 1/5] vmstate: add VMSTATE_PTIMER_ARRAY, liguang, 2013/12/11
- [Qemu-devel] [PATCH v11 4/5] hw/arm: add allwinner a10 SoC support, liguang, 2013/12/11
- [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt controller, liguang, 2013/12/11
- [Qemu-devel] [PATCH v11 2/5] hw/timer: add allwinner a10 timer, liguang, 2013/12/11
- [Qemu-devel] [PATCH v11 5/5] hw/arm: add cubieboard support, liguang, 2013/12/11